En 7716 below signed threshold #2337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,6 +26,9 @@ | |||
| # SwitchJailWaitingEnableEpoch represents the epoch when the system smart contract processing at end of epoch is enabled | |||
| SwitchJailWaitingEnableEpoch = 2 | |||
|
|
|||
| # BelowSignedThresholdEnableEpoch represents the epoch when the change for computing rating for validators below signed rating is enabled | |||
| BelowSignedThresholdEnableEpoch = 2 | |||
|
|
||
| if computedThreshold <= signedThreshold { | ||
| newTempRating := vs.rater.RevertIncreaseValidator(shardId, validator.TempRating, validator.ValidatorFailure) | ||
| increasedRatingTimes := uint32(0) | ||
| if epoch < vs.belowSignedThresholdEnableEpoch { |
There was a problem hiding this comment.
This is ok as it is. In other cases (where current epoch was unavailable) we used the epoch change notifier mechanism.
bogdan-rosianu
previously approved these changes
Oct 2, 2020
# Conflicts: # cmd/node/config/config.toml # config/config.go
iulianpascalau
approved these changes
Oct 8, 2020
bogdan-rosianu
approved these changes
Oct 8, 2020
LucianMincu
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to the economics document if a validator has a number of signatures included below 2.5% all the rating increases as a validator, validatorSuccess and validatorIgnored should be reverted for the current epoch.
Testing: start a testnet and shutdown a validator. During the first 2 epochs the validators rating should be decreased by the number of validator failures, while on the third epoch by the number of success and ignored