Refined import db process #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to have the time to commit received data - added ThresholdMinConnectedPeers as a config in order to be overridden by the import db process - made the import-db process automatically generate a new BLS key in order to avoid accidental usage of a validator BLS key that migh trigger the node shuffle-out
sasurobert
previously approved these changes
Oct 2, 2020
cmd/node/main.go
Outdated
| importCheckpointRoundsModulus := uint(config.EpochStartConfig.RoundsPerEpoch) | ||
| log.Info("import DB directory is set, altering config values!", | ||
| log.Warn("the node is import mode! Will auto-set some config values", |
factory/cryptoSigningParams.go
Outdated
| @@ -78,6 +91,21 @@ func (cspf *cryptoSigningParamsLoader) Get() (*CryptoParams, error) { | |||
| return cryptoParams, nil | |||
| } | |||
|
|
|||
| func (cspf *cryptoSigningParamsLoader) generateCryptoParams(cryptoParams *CryptoParams) (*CryptoParams, error) { | |||
| log.Warn("the node is import mode! Will generate a fresh new BLS key") | |||
SebastianMarian
previously approved these changes
Oct 2, 2020
iulianpascalau
dismissed stale reviews from SebastianMarian and sasurobert
via
fca91fb
SebastianMarian
approved these changes
Oct 5, 2020
sasurobert
approved these changes
Oct 5, 2020
LucianMincu
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the import-db process: