EN 7439 transaction routing fixes #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iulianpascalau
commented
Oct 7, 2020
iulianpascalau
commented
- removed the possibility to broadcast a transaction from any node in the network. Each transaction will get broadcast only if it will be routed to the sender's shard ID node.
- added unit and integration tests that prove that the transaction validation works as expected
… the network. Each transaction will get broadcast only if it will be routed to the sender's shard ID node.
sasurobert
previously approved these changes
Oct 7, 2020
bogdan-rosianu
requested changes
Oct 7, 2020
integrationTests/testInitializer.go
Outdated
|
|
||
| _, err := senderNode.SendTransaction(tx) | ||
| if err != nil { | ||
| log.Error("could not create transaction", "address", node.OwnAccount.Address, "error", err) |
node/node.go
Outdated
| @@ -824,7 +829,7 @@ func (n *Node) ValidateTransaction(tx *transaction.Transaction) error { | |||
| core.MaxTxNonceDeltaAllowed, | |||
| ) | |||
| if err != nil { | |||
| return nil | |||
| return fmt.Errorf("%w in Node.ValidateTransaction", err) | |||
There was a problem hiding this comment.
this will arrive in the API response. I don't think a regular user would be interested to know the method where the validation failed. Please add a log for the wrapped error and return it normally
There was a problem hiding this comment.
done. The error is now logged as warn as it is a programming error (non critical).
bogdan-rosianu
approved these changes
Oct 7, 2020
sasurobert
approved these changes
Oct 7, 2020
LucianMincu
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.