add hysteresis to minimum number of nodes #2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurobert
approved these changes
Oct 7, 2020
| } | ||
|
|
||
| newMinNodes := big.NewInt(0).SetBytes(args.Arguments[0]).Int64() | ||
| // TODO: newMinNodes extra validation? |
There was a problem hiding this comment.
there is no other access here to check. Can remain like this.
iulianpascalau
approved these changes
Oct 8, 2020
| @@ -412,5 +468,10 @@ func (s *systemSCProcessor) IsInterfaceNil() bool { | |||
| // EpochConfirmed is called whenever a new epoch is confirmed | |||
| func (s *systemSCProcessor) EpochConfirmed(epoch uint32) { | |||
| s.flagSwitchEnabled.Toggle(epoch >= s.switchEnableEpoch) | |||
|
|
|||
| // only toggle on exact epoch. In future epochs the config should have already been synchronized from peers | |||
LucianMincu
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the minimum number of nodes in the network is given to the system staking SC at genesis and is equal to
nbShards * nbEligiblePerShard
The waiting list does not have a minimum number of nodes, which means it can reach 0 nodes.
No nodes in waiting list will prevent shuffling between shards, so we need to ensure a minimum number of nodes for shuffling.
Decision is to use the hysteresis config for this, and when enabling adaptivity to add also another parameter targetHysteresis > hysteresis. Hysteresis will then be renamed to minHysteresis and used to decide merging of shards and targetHysteresis will be used to decide splitting shards.
This PR uses an enabling epoch for considering also the hysteresis in the SystemStakingSC when deciding the minimum number of nodes. For this reason a StakingSC Function was defined for updating the staking SC storage for minimum number of nodes and a SystemSC method was defined for calling the staking SC function on epochStart with the right credentials when the feature becomes active.