Import db turbo mode #2348
Import db turbo mode #2348
Conversation
iulianpascalau
commented
Oct 7, 2020
•
iulianpascalau
commented
- added extra option in import-db mode that can skip headers signature checks
- implemented disabled crypto components (suite, scalar, point, single signer & multi signer)
- disabled heartbeat sender during the import-db process
cmd/node/main.go
Outdated
| @@ -744,6 +751,7 @@ func startNode(ctx *cli.Context, log logger.Logger, version string) error { | |||
| KeyGen: cryptoParams.KeyGenerator, | |||
| PrivKey: cryptoParams.PrivateKey, | |||
| ActivateBLSPubKeyMessageVerification: systemSCConfig.StakingSystemSCConfig.ActivateBLSPubKeyMessageVerification, | |||
| UseMockSigVerifier: importDbNoSigCheckFlag, | |||
| const signature = "signature" | ||
|
|
||
| // Disabled represents a disabled singlesigner implementation | ||
| type Disabled struct { |
There was a problem hiding this comment.
singlesig.Disabled, I think it's pretty obvious
There was a problem hiding this comment.
DisabledSingleSig ? to keep the same pattern used above in crypto/signing/disabled/point.go -> DisabledPoint
and I think you can rename this file to singlesig.go and move it in crypto/signing/disabled/ folder alongside point.go ?
There was a problem hiding this comment.
done, renamed. I would keep them as they are as to comply with the rest of the crypto package implementations.
factory/cryptoComponents.go
Outdated
| @@ -9,6 +9,9 @@ import ( | |||
| "github.com/ElrondNetwork/elrond-go/crypto" | |||
| "github.com/ElrondNetwork/elrond-go/crypto/peerSignatureHandler" | |||
| "github.com/ElrondNetwork/elrond-go/crypto/signing" | |||
| disabledCrypto "github.com/ElrondNetwork/elrond-go/crypto/signing/disabled" | |||
| disabledmultisig "github.com/ElrondNetwork/elrond-go/crypto/signing/disabled/multisig" | |||
factory/cryptoComponents.go
Outdated
| @@ -9,6 +9,9 @@ import ( | |||
| "github.com/ElrondNetwork/elrond-go/crypto" | |||
| "github.com/ElrondNetwork/elrond-go/crypto/peerSignatureHandler" | |||
| "github.com/ElrondNetwork/elrond-go/crypto/signing" | |||
| disabledCrypto "github.com/ElrondNetwork/elrond-go/crypto/signing/disabled" | |||
| disabledmultisig "github.com/ElrondNetwork/elrond-go/crypto/signing/disabled/multisig" | |||
| disabledsig "github.com/ElrondNetwork/elrond-go/crypto/signing/disabled/singlesig" | |||
- removed a wrongly formatted print in interceptedUnsignedTransaction.go
| const signature = "signature" | ||
|
|
||
| // Disabled represents a disabled multisigner implementation | ||
| type Disabled struct { |
There was a problem hiding this comment.
DisabledMultiSig ? to keep the same pattern used below in crypto/signing/disabled/point.go -> DisabledPoint
and I think you can rename this file to multisig.go and move it in crypto/signing/disabled/ folder alongside point.go ?
| }() | ||
|
|
||
| d := &Disabled{} | ||
| recovInstance, err := d.Create(nil, 0) |
There was a problem hiding this comment.
recov comes from recovered ?
crypto/signing/disabled/point.go
Outdated
| return nil | ||
| } | ||
|
|
||
| // Equal return false |
| const signature = "signature" | ||
|
|
||
| // Disabled represents a disabled singlesigner implementation | ||
| type Disabled struct { |
There was a problem hiding this comment.
DisabledSingleSig ? to keep the same pattern used above in crypto/signing/disabled/point.go -> DisabledPoint
and I think you can rename this file to singlesig.go and move it in crypto/signing/disabled/ folder alongside point.go ?
crypto/signing/disabled/suite.go
Outdated
| return &disabledSuite{} | ||
| } | ||
|
|
||
| // returns the disabled string |
crypto/signing/disabled/suite.go
Outdated
| return pointLen | ||
| } | ||
|
|
||
| // CreatePoint create a disabledPoint instance |
crypto/signing/disabled/suite.go
Outdated
| return &disabledPoint{} | ||
| } | ||
|
|
||
| // CreatePointForScalar create a disabledPoint instance |
