Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/staking delegation v2 #2370

Merged
merged 366 commits into from Dec 17, 2020
Merged

Feat/staking delegation v2 #2370

merged 366 commits into from Dec 17, 2020

Conversation

iulianpascalau
Copy link
Contributor

Implementing staking and delegation v2

sasurobert and others added 25 commits October 23, 2020 21:02
…ation-tests

En 7777/delegation integration tests
…ntegration

# Conflicts:
#	cmd/node/factory/structs.go
#	epochStart/errors.go
#	epochStart/interface.go
#	epochStart/metachain/rewards.go
#	epochStart/metachain/rewards_test.go
#	epochStart/metachain/systemSCs_test.go
#	integrationTests/testProcessorNode.go
…gration

Integrated stake top-up functionality
…-2020.12.17

Merge dev feat staking v2 2020.12.17
@iulianpascalau iulianpascalau marked this pull request as ready for review December 17, 2020 11:32
sasurobert
sasurobert previously approved these changes Dec 17, 2020
@@ -21,17 +21,17 @@
RelayedTransactionsEnableEpoch = 2

# PenalizedTooMuchGasEnableEpoch represents the epoch when the penalization for using too much gas will be enabled
PenalizedTooMuchGasEnableEpoch = 2
PenalizedTooMuchGasEnableEpoch = 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not 2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


# SwitchJailWaitingEnableEpoch represents the epoch when the system smart contract processing at end of epoch is enabled
SwitchJailWaitingEnableEpoch = 2
SwitchJailWaitingEnableEpoch = 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not 2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


# BelowSignedThresholdEnableEpoch represents the epoch when the change for computing rating for validators below signed rating is enabled
BelowSignedThresholdEnableEpoch = 2
BelowSignedThresholdEnableEpoch = 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not 2?


# SwitchHysteresisForMinNodesEnableEpoch represents the epoch when the system smart contract changes its config to consider
# also (minimum) hysteresis nodes for the minimum number of nodes
SwitchHysteresisForMinNodesEnableEpoch = 2
SwitchHysteresisForMinNodesEnableEpoch = 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not 2?

UnBondPeriod = 250
MinStepValue = "100000000000000000000"
AuctionEnableEpoch = 100000
StakeEnableEpoch = 2
StakeEnableEpoch = 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not 2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

AdoAdoAdo
AdoAdoAdo previously approved these changes Dec 17, 2020
AdoAdoAdo
AdoAdoAdo previously approved these changes Dec 17, 2020
sasurobert
sasurobert previously approved these changes Dec 17, 2020
@sasurobert sasurobert dismissed stale reviews from AdoAdoAdo and themself via d9aff45 December 17, 2020 15:22
Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial tests passed.

@LucianMincu LucianMincu merged commit d57e0ec into development Dec 17, 2020
@LucianMincu LucianMincu deleted the feat/staking-delegation-v2 branch December 17, 2020 17:00
@iulianpascalau iulianpascalau restored the feat/staking-delegation-v2 branch January 20, 2021 08:49
@iulianpascalau iulianpascalau deleted the feat/staking-delegation-v2 branch March 2, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants