send back gas to relayer #2373
send back gas to relayer #2373
Conversation
process/smartContract/process.go
Outdated
| return err | ||
| } | ||
|
|
||
| err = sc.accounts.SaveAccount(userAcc) |
There was a problem hiding this comment.
return sc.accounts.SaveAccount(userAcc) ?
process/smartContract/process.go
Outdated
| var refundGasToRelayer *smartContractResult.SmartContractResult | ||
| relayedSCR, isRelayed := isRelayedTx(tx) | ||
| if isRelayed && callType != vmcommon.AsynchronousCall && refundErd.Cmp(zero) > 0 { | ||
| refundGasToRelayer = &smartContractResult.SmartContractResult{ |
There was a problem hiding this comment.
append a SCR suffix to the variable name
There was a problem hiding this comment.
also maybe rename refundErd variable to something else
| lockedGas uint64, | ||
| ) (*smartContractResult.SmartContractResult, error) { | ||
| ) (*smartContractResult.SmartContractResult, *smartContractResult.SmartContractResult, error) { |
There was a problem hiding this comment.
Although this works, returning 2 consecutive elements of the same type is always prone to faults (caused by switching variables)
There was a problem hiding this comment.
any better idea ?
There was a problem hiding this comment.
composite struct containing 3 fields (2 of them of type *smartContractResult.SmartContractResult and one of type error)
Can be left as it is
| @@ -835,6 +830,9 @@ func (sc *scProcessor) processForRelayerWhenError( | |||
| if !isRelayed { | |||
| return nil | |||
| } | |||
| if relayedSCR.Value.Cmp(zero) == 0 { | |||
There was a problem hiding this comment.
test relayedSCR.Value for nil?
There was a problem hiding this comment.
no need. it is always set.
| vmOutput *vmcommon.VMOutput, | ||
| tx data.TransactionHandler, | ||
| txHash []byte, | ||
| callType vmcommon.CallType, | ||
| ) *smartContractResult.SmartContractResult { | ||
| ) (*smartContractResult.SmartContractResult, *smartContractResult.SmartContractResult) { |
There was a problem hiding this comment.
same thing about multiple, same-type variables.
There was a problem hiding this comment.
any better idea ? :)
sasurobert
changed the base branch from
development
to
feat/esdt-relayed-arwen
sasurobert
dismissed
bogdan-rosianu’s stale review
The base branch was changed.
Improved the gas usage in case of relayed transactions. The unused gas will be sent back to the relayer itself.