Fix indexing pending problem when running in import-DB mode #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iulianpascalau
commented
Oct 23, 2020
•
iulianpascalau
commented
- made the elastic search not index transactions if the node is node in the sender shard when running in import-db
…in the destination shard when running in import-db
| @@ -35,7 +38,7 @@ func (wf *viewsFactory) Create() ([]Viewer, error) { | |||
| } | |||
|
|
|||
| func (wf *viewsFactory) createTermuiConsole() (*termuic.TermuiConsole, error) { | |||
There was a problem hiding this comment.
Done in the update branch PR
SebastianMarian
previously approved these changes
Oct 25, 2020
SebastianMarian
previously approved these changes
Oct 25, 2020
bogdan-rosianu
requested changes
Oct 26, 2020
core/indexer/elasticProcessor.go
Outdated
| ) | ||
|
|
||
| if arguments.IsInImportDBMode { | ||
| log.Warn("the node is in import mode! Elastic search will not send cross shard transactions and rewards " + |
There was a problem hiding this comment.
rephrase to cross shard transactions and rewards where destination shard is not the current node's shard won't be indexed in Elastic Search as the es is the receiver here
bogdan-rosianu
previously approved these changes
Oct 26, 2020
bogdan-rosianu
previously approved these changes
Oct 26, 2020
core/indexer/processTransactions.go
Outdated
| @@ -275,10 +275,10 @@ func (tdp *txDatabaseProcessor) groupNormalTxsAndRewards( | |||
| case block.RewardsBlock: | |||
| rTxs := getRewardsTransaction(txPool, mb.TxHashes) | |||
| for hash, rtx := range rTxs { | |||
| dbTx := tdp.commonProcessor.buildRewardTransaction(rtx, []byte(hash), mbHash, mb, header, mbTxStatus) | |||
| addToAlteredAddresses(dbTx, alteredAddresses, mb, selfShardID, true) | |||
| alteredAddresses[dbTx.Receiver] = struct{}{} | |||
There was a problem hiding this comment.
This set is ok? It is done in the method addToAlteredAddresses called above only under some certain conditions. For case block.TxBlock: above this set is not done, this is why I thought that could be something wrong here or something missed above.
There was a problem hiding this comment.
removed, thanks
SebastianMarian
approved these changes
Oct 26, 2020
bogdan-rosianu
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.