New storer events hashes by transaction hash #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miiu96
changed the title
sasurobert
requested changes
Nov 3, 2020
node/nodeTransactionsEvents.go
Outdated
| return scr, nil | ||
| } | ||
|
|
||
| func (n *Node) adaptSmartContractResult(scr *smartContractResult.SmartContractResult) *transaction.SmartContractResultApi { |
There was a problem hiding this comment.
scrToscrApi ? and maybe have the same type of function names for all these transformation (rewards, transactions, receipts) and move them to a separate file.
…nto EN-7997-events-hashes-tx-hash
andreibancioiu
requested changes
Nov 9, 2020
sasurobert
previously approved these changes
Nov 10, 2020
AdoAdoAdo
requested changes
Nov 12, 2020
| originalTxHash := string(rec.TxHash) | ||
| if eventsHashes, ok := eventsHashesMap[originalTxHash]; ok { | ||
| // append receipt hash in already create event | ||
| eventsHashes.ReceiptsHash = []byte(receiptHash) |
There was a problem hiding this comment.
if it's just 1 receipt then overwriting the receipt on the ok branch would be unreachable code right?
we could then simply create the entry for this hash always and add it to the map without checking for existence first.
| } | ||
|
|
||
| eventsHashes, err := eventsHashesIndex.getEventsHashesByTxHash(txWithReceiptHash, epoch) | ||
| require.Nil(t, err) | ||
| require.Equal(t, expectedEvents, eventsHashes) | ||
| } | ||
|
|
||
| func TestGroupSmartContractResults(t *testing.T) { |
There was a problem hiding this comment.
Before I was referring to directly testing the grouping function, but all right.
AdoAdoAdo
approved these changes
Nov 16, 2020
sasurobert
approved these changes
Nov 19, 2020
andreibancioiu
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend API route
/transaction/:hashwith a query parameter?withResults=truein order to can return also the results that are generated by a transaction:This feature will be activated if we have [DbLookupExtensions] Enabled = true