New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Top-up stake rewards #2438
Merged
Merged
Top-up stake rewards #2438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…staking data provider
…g to rewards creator
…reator, base to be reused for v2
…pdate staking data provider
sasurobert
requested changes
Nov 12, 2020
iulianpascalau
requested changes
Nov 12, 2020
sasurobert
previously approved these changes
Nov 13, 2020
iulianpascalau
approved these changes
Nov 16, 2020
sasurobert
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the rewards mechanism for variable stake per node.
Nodes still receive higher return (configurable) for the base stake (minimum nodes price), but now any extra stake can earn rewards as well.
The rewards formula for any excess stake is not linear but asymptotic to a configurable maximum, and also the starting gradient is configurable.
Backwards compatibility was implemented through a rewards creator proxy that delegates the functionality to the correct rewards model depending on the activation epoch.