En 8063 fix after rv audit #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurobert
previously approved these changes
Nov 12, 2020
| @@ -1921,7 +1888,7 @@ func (d *delegation) getFund(key []byte) (*Fund, error) { | |||
| } | |||
|
|
|||
| func (d *delegation) createAndSaveNextFund(address []byte, value *big.Int, fundType uint32) ([]byte, error) { | |||
There was a problem hiding this comment.
createAndSaveNexKeyFund
| @@ -1921,7 +1888,7 @@ func (d *delegation) getFund(key []byte) (*Fund, error) { | |||
| } | |||
|
|
|||
| func (d *delegation) createAndSaveNextFund(address []byte, value *big.Int, fundType uint32) ([]byte, error) { | |||
| fundKey, fund := d.createNextFund(address, value, fundType) | |||
| fundKey, fund := d.createNextKeyFund(address, value, fundType) | |||
| err := d.saveFund(fundKey, fund) | |||
sasurobert
requested changes
Nov 16, 2020
| @@ -1887,9 +1887,9 @@ func (d *delegation) getFund(key []byte) (*Fund, error) { | |||
| return dFund, nil | |||
| } | |||
|
|
|||
| func (d *delegation) createAndSaveNextFund(address []byte, value *big.Int, fundType uint32) ([]byte, error) { | |||
| func (d *delegation) createAndSaveNexKeyFund(address []byte, value *big.Int, fundType uint32) ([]byte, error) { | |||
There was a problem hiding this comment.
createAndSaveNextKeyFund ? however KeyFund does not sound so right. and saveKeyFund might be renamed again to saveFund - as it only safe the fund data.
SebastianMarian
approved these changes
Nov 16, 2020
sasurobert
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed duplicated code and implemented other small optimizations.