max number of shards for genesis config #2521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdoAdoAdo
changed the title
sasurobert
previously approved these changes
Nov 27, 2020
BeniaminDrasovean
previously approved these changes
Nov 27, 2020
AdoAdoAdo
dismissed stale reviews from BeniaminDrasovean and sasurobert
via
4cd9fec
sasurobert
approved these changes
Nov 27, 2020
BeniaminDrasovean
approved these changes
Nov 27, 2020
LucianMincu
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add maximum number of shards for genesis nodes config
This will allow more flexible initial test-net nodes config.
Should be backwards compatible, as long as the set maximum number of shards >= with the legacy end result (3 shards without MetaChain)
Legacy implementation would have split the nodes into maximum number of shards allowed by the constraints (number of eligible nodes per shard + minimum hysteresis for waiting nodes), now even if more shards could be created, the given maximum number of shards is kept as a hard limit, the remaining nodes being distributed to the shards waiting lists.