En 8398 tests transactions #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # process/transaction/export_test.go # process/transaction/shardProcess_test.go
sasurobert
requested changes
Dec 17, 2020
| "math" | ||
| "math/big" | ||
| "strconv" | ||
| "testing" | ||
|
|
||
| "github.com/ElrondNetwork/elrond-go/process/block/preprocess" |
process/transaction/export_test.go
Outdated
| @@ -57,9 +58,10 @@ func (txProc *txProcessor) ProcessUserTx( | |||
|
|
|||
| func (txProc *txProcessor) TakeMoveBalanceCostOutOfUser( | |||
There was a problem hiding this comment.
Rename also this method to ProcessMoveBalanceCostRelayedUserTx
| vm.TestAccount(t, testContext.Accounts, owner, 2, expectedBalance) | ||
|
|
||
| // check accumulated fees | ||
| accumulatedFee := testContext.TxFeeHandler.GetAccumulatedFees() |
There was a problem hiding this comment.
You can search everywhere after this message: // check accumulated fees , and replace the below variable name from
accumulatedFee to accumulatedFees
# Conflicts: # integrationTests/vm/testInitializer.go # process/transaction/shardProcess_test.go
sasurobert
previously approved these changes
Dec 18, 2020
| @@ -134,12 +134,12 @@ func TestMoveBalanceHigherNonceShouldNotConsumeGas(t *testing.T) { | |||
| vm.TestAccount(t, testContext.Accounts, sndAddr, 0, expectedBalance) | |||
|
|
|||
| // check accumulated fees | |||
| accumulatedFee := testContext.TxFeeHandler.GetAccumulatedFees() | |||
| require.Equal(t, big.NewInt(0), accumulatedFee) | |||
| accumulatedFeess := testContext.TxFeeHandler.GetAccumulatedFees() | |||
SebastianMarian
approved these changes
Dec 18, 2020
sasurobert
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a lot of integration tests that verify if the transaction processor works as exepected.