EN-8515: Linter issues #2609
Merged
EN-8515: Linter issues #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facade/errors.go
Outdated
| @@ -23,5 +23,5 @@ var ErrNilPeerState = errors.New("nil peer state") | |||
| // ErrNilAccountState signals that a nil account state has been provided | |||
| var ErrNilAccountState = errors.New("nil account state") | |||
|
|
|||
| // ErrNilTransactionSimulatorProcessor signals that a nil transaction simulator processor has been provided | |||
| // ErrErrNilTransactionSimulatorProcessor signals that a nil transaction simulator processor has been provided | |||
There was a problem hiding this comment.
Remove double ErrErr from comment and error variable also
| for key := range chunk.items { | ||
| keys = append(keys, key) | ||
| } | ||
| chunk.mutex.RUnlock() |
| @@ -148,11 +148,10 @@ func (m *ConcurrentMap) Keys() []string { | |||
|
|
|||
| for _, chunk := range chunks { | |||
| chunk.mutex.RLock() | |||
There was a problem hiding this comment.
I think you can move this RLock in line 148 and RUnlock from line 154 to line 156, just to avoid multiple locks/unlocks
There was a problem hiding this comment.
no, I can't because the mutex belongs to the chunk element from the range
sasurobert
previously approved these changes
Dec 18, 2020
SebastianMarian
previously approved these changes
Dec 18, 2020
# Conflicts: # epochStart/metachain/epochStartData.go
SebastianMarian
approved these changes
Dec 19, 2020
sasurobert
approved these changes
Dec 19, 2020
LucianMincu
approved these changes
Dec 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed relevant issues found by linters. (GoLand built-in linters + GolangCI)