Fix/owner cleanup delegation #2630
Conversation
sasurobert
commented
Dec 30, 2020
•
sasurobert
commented
- fixed the wrong owner key hex encoding
- fixed the getUnStakedTokensList view function
| @@ -1447,7 +1447,7 @@ func (s *stakingSC) getOwner(args *vmcommon.ContractCallInput) vmcommon.ReturnCo | |||
| return vmcommon.UserError | |||
| } | |||
|
|
|||
| s.eei.Finish([]byte(hex.EncodeToString(stakedData.OwnerAddress))) | |||
| s.eei.Finish(stakedData.OwnerAddress) | |||
There was a problem hiding this comment.
There still are some s.eei.Finish() with hexEncode on the RewardAddress: lines 1273 and 1384. Should not all be not hexEncoded?
There was a problem hiding this comment.
I have implemented this and indeed I have used the other examples in the system SC. What we have figure out today is that this hex encoding is useless as we need a complementary hex.Decode call when processing internal data. The code is now slightly optimized and one bug was fixed. If we need an API function for the owner field we will create a new function that will return the data in hex format.
| @@ -70,27 +70,32 @@ func TestDelegationSystemNodesOperations(t *testing.T) { | |||
| checkNodesStatus(t, tpn, vm.StakingSCAddress, blsKeys[:numNodesToStake], "staked") | |||
|
|
|||
| //unStake 3 nodes | |||
There was a problem hiding this comment.
is this comment still relevant? You basically unstake all 5 nodes.
There was a problem hiding this comment.
Not more relevant
| @@ -1447,7 +1447,7 @@ func (s *stakingSC) getOwner(args *vmcommon.ContractCallInput) vmcommon.ReturnCo | |||
| return vmcommon.UserError | |||
| } | |||
|
|
|||
| s.eei.Finish([]byte(hex.EncodeToString(stakedData.OwnerAddress))) | |||
| s.eei.Finish(stakedData.OwnerAddress) | |||
There was a problem hiding this comment.
I have implemented this and indeed I have used the other examples in the system SC. What we have figure out today is that this hex encoding is useless as we need a complementary hex.Decode call when processing internal data. The code is now slightly optimized and one bug was fixed. If we need an API function for the owner field we will create a new function that will return the data in hex format.
