Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/eip esdt local mint #2846

Merged
merged 293 commits into from
Apr 14, 2021
Merged

Feat/eip esdt local mint #2846

merged 293 commits into from
Apr 14, 2021

Conversation

sasurobert
Copy link
Contributor

@sasurobert sasurobert commented Feb 24, 2021

  • Added localBurn and localMint feature on ESDT
  • Added NFT support based on ESDT functionality

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #2846 (c65938c) into master (d93bfa9) will increase coverage by 0.03%.
The diff coverage is 71.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2846      +/-   ##
==========================================
+ Coverage   75.02%   75.06%   +0.03%     
==========================================
  Files         620      629       +9     
  Lines       59094    60655    +1561     
==========================================
+ Hits        44337    45531    +1194     
- Misses      10803    11020     +217     
- Partials     3954     4104     +150     
Impacted Files Coverage Δ
core/vmcommon/output.go 84.21% <ø> (ø)
data/vm/vmOutputApi.go 76.92% <ø> (ø)
...artContract/builtInFunctions/changeOwnerAddress.go 64.70% <0.00%> (+5.33%) ⬆️
.../smartContract/builtInFunctions/keyValueStorage.go 79.66% <0.00%> (+4.22%) ⬆️
process/smartContract/common.go 83.33% <ø> (-2.39%) ⬇️
process/smartContract/hooks/blockChainHook.go 56.44% <0.00%> (+3.43%) ⬆️
vm/systemSmartContracts/esdt.go 73.08% <ø> (-1.43%) ⬇️
facade/nodeFacade.go 43.45% <15.38%> (+0.28%) ⬆️
process/smartContract/builtInFunctions/factory.go 40.20% <32.43%> (-1.95%) ⬇️
process/smartContract/builtInFunctions/esdtBurn.go 56.86% <44.44%> (-5.64%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d93bfa9...c65938c. Read the comment docs.

sasurobert and others added 29 commits March 2, 2021 15:14
Extend tests for ESDT transfers with execution
# Conflicts:
#	process/smartContract/builtInFunctions/esdtRoles.go
@iulianpascalau iulianpascalau dismissed stale reviews from dorin-iancu and themself via 9aed54b April 13, 2021 12:46
iulianpascalau
iulianpascalau previously approved these changes Apr 13, 2021
iulianpascalau
iulianpascalau previously approved these changes Apr 14, 2021
raduchis
raduchis previously approved these changes Apr 14, 2021
dorin-iancu
dorin-iancu previously approved these changes Apr 14, 2021
@LucianMincu LucianMincu merged commit 9c091a5 into master Apr 14, 2021
@LucianMincu LucianMincu deleted the feat/eip-esdt-local-mint branch April 14, 2021 07:48
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants