Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend tests for ESDT transfers with execution #2858

Merged
merged 20 commits into from
Mar 2, 2021

Conversation

camilbancioiu
Copy link
Contributor

@camilbancioiu camilbancioiu commented Feb 26, 2021

This PR adds:

  • Updated forwarder-raw.wasm binary and appropriate updates in the integration tests
  • Extra test calls using the forwarder-raw smart contract to test the transferESDTExecute() EEI method.
  • The TxDataBuilder
  • Updated commit reference to Arwen's master branch.

Copy link
Contributor

@iulianpascalau iulianpascalau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good implementation! Mostly styling/formatting issues.

integrationTests/vm/esdt/esdtProcess_test.go Outdated Show resolved Hide resolved
integrationTests/vm/esdt/esdtProcess_test.go Outdated Show resolved Hide resolved
integrationTests/vm/esdt/esdtProcess_test.go Outdated Show resolved Hide resolved
integrationTests/vm/esdt/esdtProcess_test.go Outdated Show resolved Hide resolved
integrationTests/vm/esdt/esdtProcess_test.go Outdated Show resolved Hide resolved
integrationTests/vm/txDataBuilder.go Outdated Show resolved Hide resolved
integrationTests/vm/txDataBuilder.go Outdated Show resolved Hide resolved
integrationTests/vm/txDataBuilder.go Outdated Show resolved Hide resolved
integrationTests/vm/txDataBuilder.go Outdated Show resolved Hide resolved
integrationTests/vm/txDataBuilder.go Outdated Show resolved Hide resolved
@sasurobert sasurobert self-requested a review March 1, 2021 07:47
return builder.Str("canMint").Bool(prop)
}

func (builder *TxDataBuilder) CanBurn(prop bool) *TxDataBuilder {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add an IsInterfaceNil

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

@iulianpascalau iulianpascalau merged commit 48f9ebb into feat/eip-esdt-local-mint Mar 2, 2021
@iulianpascalau iulianpascalau deleted the esdt-multitransfer branch March 2, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants