Fix prerequisites.sh #2873
Merged
Fix prerequisites.sh #2873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case PRIVATE_REPOS is not defined, the script will exit with error. Using double brackets will take care of this case.
Codecov Report
@@ Coverage Diff @@
## master #2873 +/- ##
=======================================
Coverage 74.81% 74.81%
=======================================
Files 613 613
Lines 58512 58512
=======================================
Hits 43776 43776
Misses 10801 10801
Partials 3935 3935 Continue to review full report at Codecov.
|
scripts/testnet/prerequisites.sh
Outdated
| @@ -56,7 +56,7 @@ fi | |||
| cd $(dirname $ELRONDDIR) | |||
| git clone git@github.com:ElrondNetwork/elrond-deploy-go.git | |||
|
|
|||
| if [ $PRIVATE_REPOS -eq 1 ]; then | |||
| if [[ $PRIVATE_REPOS -eq 1 ]]; then | |||
| git clone git@github.com:ElrondNetwork/elrond-proxy-go.git | |||
There was a problem hiding this comment.
can you please take out this line outside of this if branch? elrond-proxy-go is no longer a private repo :)
iulianpascalau
previously approved these changes
Mar 3, 2021
sasurobert
previously approved these changes
Mar 23, 2021
iulianpascalau
dismissed stale reviews from sasurobert and themself
The base branch was changed.
iulianpascalau
approved these changes
Apr 12, 2021
sasurobert
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case PRIVATE_REPOS is not defined, the script will exit with error. Using double brackets will take care of this case.