Shard scheduled mini blocks pre-validation #2889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added scheduled mini blocks in the proposed body
… be added in sender shard block * Fixed wrong initialization of totalGasConsumedInSelfShard in method createScheduledMiniBlocks * Optimized the order of some operations done inside createAndProcessMiniBlocksFromMeV2 and createScheduledMiniBlocks methods
SebastianMarian
changed the title
sasurobert
requested changes
Mar 15, 2021
…ped/handled correctly at destination (these actions are needed only for now, and will be reverted when processing of scheduled mini blocks will be done in the source shard)
…CTxs contains some of the scheduled txs, before calling the createScheduledMiniBlocks method
…l should be done with mocked methods isShardStuckFalse and isMaxBlockSizeReachedFalse)
SebastianMarian
changed the base branch from
feat/scheduled-SC-execution
to
feat/scheduled-sc-execution
…locks_prevalidation # Conflicts: # process/block/preprocess/transactionsV2.go
sasurobert
approved these changes
Mar 26, 2021
AdoAdoAdo
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to be tested
Start a normal system test with txs and sc calls
In epoch 5 scheduled mini blocks mechanism will be activated.
In epoch 6 we should check the log files and messages like: "createScheduledMiniBlocks has been started", "createScheduledMiniBlocks has been finished" and "scheduled mini blocks from me created" should be found