Execution component for scheduled transactions #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurobert
requested changes
Mar 22, 2021
| @@ -640,6 +628,12 @@ func (txs *transactions) verifyTransaction( | |||
| txs.mutAccountsInfo.Unlock() | |||
|
|
|||
| if err != nil { | |||
| isTxTargetedForDeletion := errors.Is(err, process.ErrLowerNonceInTransaction) || errors.Is(err, process.ErrInsufficientFee) | |||
There was a problem hiding this comment.
maybe use a small DTO for line 598-601
…rocessor * Fixed after review
sasurobert
previously approved these changes
Mar 23, 2021
AdoAdoAdo
previously approved these changes
Mar 25, 2021
Base automatically changed from
shard_scheduled_miniblocks_prevalidation
to
feat/scheduled-sc-execution
March 29, 2021 13:37
SebastianMarian
dismissed stale reviews from AdoAdoAdo and sasurobert
The base branch was changed.
…or-scheduled-transactions # Conflicts: # process/block/argProcessor.go # process/block/baseProcess.go # process/interface.go
* Reduced additional time allocated for creating scheduled mini blocks
sasurobert
approved these changes
Mar 29, 2021
AdoAdoAdo
approved these changes
Mar 30, 2021
SebastianMarian
deleted the
execution-component-for-scheduled-transactions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to be tested
Start a normal system test with txs and sc calls
In epoch 5 scheduled mini blocks mechanism will be activated.
In epoch 6 we should check the log files and messages like: "createScheduledMiniBlocks has been started", "createScheduledMiniBlocks has been finished" and "scheduled mini blocks from me created" should be found