EN-9416/new api to get NFT data #2925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdan-rosianu
requested changes
Mar 24, 2021
bogdan-rosianu
previously approved these changes
Mar 24, 2021
Co-authored-by: bogdan-rosianu <51945539+bogdan-rosianu@users.noreply.github.com>
bogdan-rosianu
approved these changes
Mar 24, 2021
miiu96
reviewed
Mar 24, 2021
| Name string `json:"name"` | ||
| Creator string `json:"creator"` | ||
| Royalties string `json:"royalties"` | ||
| Hash []byte `json:"hash"` |
There was a problem hiding this comment.
Why Hash field is not a string?
Ask this question because everywhere on the API we return hash (hash of a block or hash of a transaction, etc) as string hex-encoded.
There was a problem hiding this comment.
in case of address codehash is returned as byte array.
| return | ||
| } | ||
|
|
||
| nonceAsStr := c.Param("nonce") |
There was a problem hiding this comment.
Can you make a method here getNonceParam where you read the nonce parameter and do the cast?
There was a problem hiding this comment.
would leave as it is.
| @@ -34,12 +34,18 @@ var ErrGetESDTTokens = errors.New("get esdt tokens for account error") | |||
| // ErrGetESDTBalance signals an error in getting esdt balance for given address | |||
| var ErrGetESDTBalance = errors.New("get esdt balance for account error") | |||
|
|
|||
| // ErrGetESDTNFTData signals an error in getting esdt nft data for given address, tokenID and nonce | |||
| var ErrGetESDTNFTData = errors.New("get esdt nft data for account error") | |||
There was a problem hiding this comment.
can you change please the text of this error? ("cannot get esdt nft data for account" )
There was a problem hiding this comment.
followed all the error messages from this file
miiu96
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented new api to get NFT data