EN-9416/all-esdt-api #2938
Merged
EN-9416/all-esdt-api #2938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdan-rosianu
requested changes
Mar 30, 2021
api/address/routes.go
Outdated
| @@ -23,6 +23,7 @@ const ( | |||
| getESDTTokens = "/:address/esdt" | |||
| getESDTBalance = "/:address/esdt/:tokenIdentifier" | |||
| getESDTNFTData = "/:address/esdtnft/:tokenIdentifier/nonce/:nonce" | |||
| getAllESDTData = "/:address/completeEsdts" | |||
There was a problem hiding this comment.
can we remove the /:address/esdt and use this one instead? I don't see why we would keep 2 endpoints, one that contains less info, and one that contains more info
ccorcoveanu
requested changes
Mar 30, 2021
api/address/routes.go
Outdated
| @@ -23,6 +23,7 @@ const ( | |||
| getESDTTokens = "/:address/esdt" | |||
| getESDTBalance = "/:address/esdt/:tokenIdentifier" | |||
| getESDTNFTData = "/:address/esdtnft/:tokenIdentifier/nonce/:nonce" | |||
There was a problem hiding this comment.
Maybe rename esdtnft to simply nft? The longer version would translate to Elrond Standard Digital Token Non Fungible Token
bogdan-rosianu
previously approved these changes
Mar 30, 2021
ccorcoveanu
previously approved these changes
Mar 30, 2021
bogdan-rosianu
dismissed stale reviews from ccorcoveanu and themself
via
4c61ffd
bogdan-rosianu
previously approved these changes
Mar 30, 2021
bogdan-rosianu
approved these changes
Mar 30, 2021
ccorcoveanu
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all new api to get all information from a given user on esdts