Delete list from esdt #2941
Merged
Delete list from esdt #2941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulianpascalau
approved these changes
Mar 31, 2021
| @@ -2499,3 +2501,28 @@ func (tpn *TestProcessorNode) createHeartbeatWithHardforkTrigger(heartbeatPk str | |||
| err = tpn.Node.StartHeartbeat(hbConfig, "test", config.PreferencesConfig{}) | |||
| log.LogIfError(err) | |||
| } | |||
|
|
|||
| // GetTokenIdentifier returns the token identifier from the metachain for the given ticker | |||
| func GetTokenIdentifier(nodes []*TestProcessorNode, ticker []byte) []byte { | |||
| @@ -164,8 +163,6 @@ func (e *esdt) Execute(args *vmcommon.ContractCallInput) vmcommon.ReturnCode { | |||
| return e.controlChanges(args) | |||
| case "transferOwnership": | |||
| return e.transferOwnership(args) | |||
| case "getAllESDTTokens": | |||
There was a problem hiding this comment.
So we can not get all tokens list straight from the esdt contract now, right? As an alternative, do we to iterate some leaves over a data trie in case we need that list?
There was a problem hiding this comment.
Exactly. Or index it in elastic search
SebastianMarian
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deleted all token list from esdt metachain system sc