Fix trie sync OOM problems #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iulianpascalau
commented
Mar 31, 2021
iulianpascalau
commented
- fix trie sync OOM problems
Codecov Report
@@ Coverage Diff @@
## feat/trie-sync-fixes #2946 +/- ##
========================================================
+ Coverage 74.89% 74.91% +0.01%
========================================================
Files 613 613
Lines 58669 58645 -24
========================================================
- Hits 43941 43933 -8
+ Misses 10797 10783 -14
+ Partials 3931 3929 -2
Continue to review full report at Codecov.
|
sasurobert
reviewed
Mar 31, 2021
update/sync/syncAccountsDBs.go
Outdated
| @@ -155,7 +155,8 @@ func (st *syncAccountsDBs) syncAccountsOfType(accountType genesis.Type, trieID s | |||
| return err | |||
| } | |||
|
|
|||
| st.setTries(shardId, accAdapterIdentifier, rootHash, accountsDBSyncer.GetSyncedTries()) | |||
| //TODO(iulian) fix here in this PR | |||
There was a problem hiding this comment.
this whole thing works without this :D maybe from accountsDBSyncer you can take those.
sasurobert
previously approved these changes
Apr 7, 2021
sasurobert
previously approved these changes
Apr 7, 2021
| @@ -157,7 +156,9 @@ func (u *userAccountsSyncer) syncDataTrie(rootHash []byte, ssh data.SyncStatisti | |||
| return err | |||
There was a problem hiding this comment.
Not need to call u.throttler.EndProcessing() on return err cases in this method ?
sasurobert
approved these changes
Apr 7, 2021
SebastianMarian
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.