Formatted NFT identifier in api response #2949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurobert
previously approved these changes
Mar 31, 2021
sasurobert
previously approved these changes
Mar 31, 2021
miiu96
reviewed
Mar 31, 2021
| @@ -49,10 +49,7 @@ | |||
| { Name = "/:address/esdt/:tokenIdentifier", Open = true }, | |||
|
|
|||
| # /address/:address/nft/:tokenIdentifier/nonce/:nonce will return data of an nft esdt token for a given account, tokenID and nonce | |||
There was a problem hiding this comment.
data of a nft instead data of an nft
There was a problem hiding this comment.
actually, using an is correct
node/node.go
Outdated
| @@ -60,6 +60,8 @@ import ( | |||
| // SendTransactionsPipe is the pipe used for sending new transactions | |||
| const SendTransactionsPipe = "send transactions pipe" | |||
|
|
|||
| const esdtTickerNumChars = 6 | |||
There was a problem hiding this comment.
group these constants
const(
..
..
)
| @@ -390,6 +390,73 @@ func TestNode_GetAllESDTTokens(t *testing.T) { | |||
| assert.Equal(t, esdtData, value[esdtToken]) | |||
| } | |||
|
|
|||
| func TestNode_GetAllESDTTokensShouldReturnEsdtAndFormattedNft(t *testing.T) { | |||
| acc, _ := state.NewUserAccount([]byte("newaddress")) | |||
There was a problem hiding this comment.
no test in this file contains t.Parallel() so I would leave it as it is
# Conflicts: # node/node_test.go
sasurobert
previously approved these changes
Apr 1, 2021
sasurobert
approved these changes
Apr 1, 2021
miiu96
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatted the NFT identifier in
/address/:address/esdtendpoint.Now, if a token is regular esdt, the key for it would follow the syntax
TICKER-3e3e3eand if it the token is a NFT, then it would follow the syntaxTICKER-3e3e3e-02where02is the hex encoded nonce.Before this PR, the token identifier for NFTs would have resulted in non readable characters