sharding: balance shards waiting lists with shuffled out nodes #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2950 +/- ##
==========================================
+ Coverage 75.01% 75.02% +0.01%
==========================================
Files 620 620
Lines 59062 59086 +24
==========================================
+ Hits 44305 44329 +24
Misses 10803 10803
Partials 3954 3954
Continue to review full report at Codecov.
|
sasurobert
reviewed
Apr 2, 2021
sharding/hashValidatorShuffler.go
Outdated
| err = distributeValidators(newWaiting, arg.newNodes, arg.randomness) | ||
|
|
||
| err = distributeValidators(newWaiting, arg.newNodes, arg.randomness, false) | ||
|
|
sharding/hashValidatorShuffler.go
Outdated
| @@ -657,6 +706,9 @@ func (rhs *randHashShuffler) UpdateShufflerConfig(epoch uint32) { | |||
| "epochEnable", rhs.activeNodesConfig.EpochEnable, | |||
| "maxNodesToShufflePerShard", rhs.activeNodesConfig.NodesToShufflePerShard, | |||
| ) | |||
|
|
|||
| rhs.flagBalanceWaitingLists.Toggle(epoch >= rhs.balanceWaitingListsEnableEpoch) | |||
| log.Trace("balanced waiting lists", "enabled", rhs.flagBalanceWaitingLists.IsSet()) | |||
There was a problem hiding this comment.
log.Debug as to align with the rest of the project.
iulianpascalau
approved these changes
Apr 6, 2021
sasurobert
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with activation of capped shuffling of nodes, the shards waiting lists may become unbalanced
this may cause waiting times to differ between shards waiting lists
this PR will try at the end of each epoch to first equalize the waiting lists.