added new api to get all issued esdts #2951
Conversation
node/node.go
Outdated
| // GetAllIssuedESDTs returns all the issued esdt tokens, works if not is on metachain | ||
| func (n *Node) GetAllIssuedESDTs() ([]string, error) { | ||
| if n.shardCoordinator.SelfId() != core.MetachainShardId { | ||
| return nil, ErrAccountNotFound |
There was a problem hiding this comment.
can you return another error because is not so intuitive for the user if gets this error.
There was a problem hiding this comment.
deleted as not used
node/node.go
Outdated
| @@ -444,6 +445,48 @@ func (n *Node) GetUsername(address string) (string, error) { | |||
| return string(username), nil | |||
| } | |||
|
|
|||
| // GetAllIssuedESDTs returns all the issued esdt tokens, works if not is on metachain | |||
There was a problem hiding this comment.
works only on the metachain node ?
| return nil, ErrAccountNotFound | ||
| } | ||
|
|
||
| account, err := n.accounts.GetExistingAccount(vm.ESDTSCAddress) |
There was a problem hiding this comment.
please add a todo here to modify this implementation with the modifications from this branch 'fix-network-economics'
cmd/node/config/api.toml
Outdated
| { Name = "/config", Open = true }, | ||
|
|
||
| # /network/esdts will return all the issued esdts on the protocol | ||
| { Name = "/esdts", Open = true }, |
facade/nodeFacade.go
Outdated
| @@ -287,6 +287,11 @@ func (nf *nodeFacade) GetAllESDTTokens(address string) (map[string]*esdt.ESDigit | |||
| return nf.node.GetAllESDTTokens(address) | |||
| } | |||
|
|
|||
| // GetAllIssuedESDTs returns all the issued esdts for a given address | |||
There was a problem hiding this comment.
// GetAllIssuedESDTs returns all the issued esdts from the esdt system smart contract
|
|
||
| for leaf := range chLeaves { | ||
| key := string(leaf.Key()) | ||
| if strings.Contains(key, "-") { |
There was a problem hiding this comment.
is this enough? we have to make sure no other key would contain -
facade/nodeFacade.go
Outdated
| @@ -287,6 +287,11 @@ func (nf *nodeFacade) GetAllESDTTokens(address string) (map[string]*esdt.ESDigit | |||
| return nf.node.GetAllESDTTokens(address) | |||
| } | |||
|
|
|||
| // GetAllIssuedESDTs returns all the issued esdts for a given address | |||
There was a problem hiding this comment.
It is not for a given address, refactor the comment
|
|
||
| for leaf := range chLeaves { | ||
| key := string(leaf.Key()) | ||
| if strings.Contains(key, "-") { |
There was a problem hiding this comment.
So "-" should be reserved only for esdt as a symbol used in the key
added new api to get all issued esdts