Refactor and add unit tests for scheduled sc execution #2956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SebastianMarian
commented
Apr 2, 2021
•
SebastianMarian
commented
- Added unit tests for scheduled txs execution component
- Refactor transactionsV2
SebastianMarian
changed the title
sasurobert
requested changes
Apr 7, 2021
| maxCrossShardScCallsOrSpecialTxsPerShard := 0 | ||
|
|
||
| processingInfo := processedTxsInfo{} | ||
| cpmbi := txs.initCreateAndProcessMiniBlocks() |
There was a problem hiding this comment.
maybe some better name. it is complicated - cpmbi
| } | ||
|
|
||
| senderAddressToSkip := []byte("") | ||
| csmbi := txs.initCreateScheduledMiniBlocks() |
There was a problem hiding this comment.
there is little diference between csmbi and cpmbi from line 204.
| txs.blockSizeComputation.AddNumMiniBlocks(1) | ||
| } | ||
| csmbi.mapCrossShardScCallTxs[receiverShardID]++ | ||
| if csmbi.mapCrossShardScCallTxs[receiverShardID] > csmbi.maxCrossShardScCallTxsPerShard { |
There was a problem hiding this comment.
csmbi.mapCrossShardScCallTxs[receiverShardID] take out into a variable
| cpmbi.firstCrossShardScCallOrSpecialTxFound = true | ||
| txs.blockSizeComputation.AddNumMiniBlocks(1) | ||
| } | ||
| cpmbi.mapCrossShardScCallsOrSpecialTxs[receiverShardID]++ |
There was a problem hiding this comment.
cpmbi.mapCrossShardScCallsOrSpecialTxs[receiverShardID] take out into a separate variable
| } | ||
|
|
||
| isMiniBlockEmpty := len(miniBlock.TxHashes) == 0 | ||
| firstMiniBlockSplitForReceiverShardFound := (txMbInfo.isReceiverSmartContractAddress && cpmbi.mapScsForShard[receiverShardID] == 0 && cpmbi.mapTxsForShard[receiverShardID] > 0) || |
There was a problem hiding this comment.
this is an incredibly complicated condition. can we make it easier ?
SebastianMarian
commented
Apr 16, 2021
|
|
||
| senderAddressToSkip = []byte("") | ||
|
|
||
| gasRefunded := txs.gasHandler.GasRefunded(txHash) |
There was a problem hiding this comment.
This gasRefunded approach should be modified exactly like in PR: #3016
…ts-for-scheduled-sc-execution
…duled-sc-execution' into refactor-and-unit-tests-for-scheduled-sc-execution
AdoAdoAdo
approved these changes
Apr 19, 2021
sasurobert
approved these changes
Apr 19, 2021
AdoAdoAdo
deleted the
refactor-and-unit-tests-for-scheduled-sc-execution
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.