Feat/trie sync fixes #2966
Merged
Feat/trie sync fixes #2966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added the possibility to switch from the 2 implementations from the config lines
…e-sync-optimization
- made the trie sync tests use real life storers
…e-sync-optimization
…e-sync-optimization
Fix trie sync OOM problems
Codecov Report
@@ Coverage Diff @@
## master #2966 +/- ##
==========================================
+ Coverage 74.89% 74.97% +0.07%
==========================================
Files 613 615 +2
Lines 58677 58857 +180
==========================================
+ Hits 43949 44130 +181
+ Misses 10797 10789 -8
- Partials 3931 3938 +7
Continue to review full report at Codecov.
|
- tweaked configs
# Conflicts: # data/syncer/userAccountsSyncer.go # data/trie/branchNode.go # data/trie/branchNode_test.go # data/trie/extensionNode.go # data/trie/extensionNode_test.go # data/trie/interface.go # data/trie/leafNode.go # data/trie/sync.go
More tries sync fixes
Trie sync optimization
sasurobert
approved these changes
Apr 9, 2021
raduchis
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync trie fixes so the node will not raise an Out Of Memory exception during bootstrap
Added a new variant of trie syncer which should perform better