More tries sync fixes #2967
Merged
More tries sync fixes #2967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iulianpascalau
commented
Apr 7, 2021
iulianpascalau
commented
- fixed the wrong trie node size estimation when inserting an intercepted trie node in the cache
- made the trie syncer to not depend upon a trie instance
- tweaked configs
sasurobert
reviewed
Apr 8, 2021
data/trie/branchNode.go
Outdated
| } | ||
|
|
||
| // hasher + marshalizer + dirty flag = 2 * pointerSizeInBytes + 1 | ||
| nodeSize := len(bn.hash) + 2*pointerSizeInBytes + 1 |
There was a problem hiding this comment.
maybe add a constant for "2"
| return 0 | ||
| } | ||
|
|
||
| // hasher + marshalizer + child + dirty flag = 3 * pointerSizeInBytes + 1 |
There was a problem hiding this comment.
maybe add a constant for "2"
There was a problem hiding this comment.
this is 3, btw :)
data/trie/leafNode.go
Outdated
| return 0 | ||
| } | ||
|
|
||
| // hasher + marshalizer + dirty flag = 2 * pointerSizeInBytes + 1 |
There was a problem hiding this comment.
maybe add a constant for "2"
| @@ -285,10 +282,11 @@ func (ts *trieSyncer) getNode(hash []byte) (node, error) { | |||
|
|
|||
| n, ok := ts.interceptedNodes.Get(hash) | |||
| if ok { | |||
| ts.interceptedNodes.Remove(hash) | |||
There was a problem hiding this comment.
the interceptor does not delete the unused infos ?
There was a problem hiding this comment.
no, it just stores in the cache what it receives. Just like in the case of transactions, blocks and so on.
BeniaminDrasovean
previously approved these changes
Apr 8, 2021
BeniaminDrasovean
approved these changes
Apr 8, 2021
sasurobert
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.