Calculate gas for built in functions #2977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
miiu96
commented
Apr 8, 2021
•
miiu96
commented
- Calculate the gas cost for built-in functions like ESDT Transfer,ESDT Local Burn,ESDT Local Mint, etc
…ial-built-in-functions
miiu96
changed the title
sasurobert
requested changes
Apr 9, 2021
process/economics/interface.go
Outdated
| // BuiltInFunctionsCostHandler is able to calculated the cost of a built in function call | ||
| type BuiltInFunctionsCostHandler interface { | ||
| ComputeBuiltInCost(tx process.TransactionWithFeeHandler) uint64 | ||
| IsSpecialBuiltIn(tx process.TransactionWithFeeHandler) bool |
| } | ||
|
|
||
| // IsSpecialBuiltIn will check is the provided transaction is a special build in function call | ||
| func (bc *builtInFunctionsCost) IsSpecialBuiltIn(tx process.TransactionWithFeeHandler) bool { |
There was a problem hiding this comment.
rename to IsBuiltInFuncCall ?
AdoAdoAdo
requested changes
Apr 9, 2021
AdoAdoAdo
reviewed
Apr 9, 2021
| // IsSpecialBuiltIn - | ||
| func (b BuiltInCostHandlerStub) IsSpecialBuiltIn(_ process.TransactionWithFeeHandler) bool { | ||
| // IsBuiltInFuncCall - | ||
| func (b BuiltInCostHandlerStub) IsBuiltInFuncCall(_ process.TransactionWithFeeHandler) bool { |
There was a problem hiding this comment.
can you change to pointer receiver everywhere?
| // IsSpecialBuiltIn - | ||
| func (b BuiltInCostHandlerStub) IsSpecialBuiltIn(_ process.TransactionWithFeeHandler) bool { | ||
| // IsBuiltInFuncCall - | ||
| func (b BuiltInCostHandlerStub) IsBuiltInFuncCall(_ process.TransactionWithFeeHandler) bool { |
There was a problem hiding this comment.
can you change to pointer receiver everywhere?
(a transaction that does an NFT Transfer will have the "gasUsed" field equal with gas limit) and the remaining gas will be seen in SCR)
…ial-built-in-functions
…ial-built-in-functions
sasurobert
approved these changes
Apr 12, 2021
…ial-built-in-functions
AdoAdoAdo
approved these changes
Apr 12, 2021
…ial-built-in-functions
iulianpascalau
deleted the
calculate-gas-limit-special-built-in-functions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.