Delete nil esdt data #2980
Merged
Delete nil esdt data #2980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdan-rosianu
approved these changes
Apr 9, 2021
| func saveESDTData( | ||
| userAcnt state.UserAccountHandler, | ||
| esdtData *esdt.ESDigitalToken, | ||
| key []byte, | ||
| marshalizer marshal.Marshalizer, | ||
| ) error { | ||
| isValueZero := esdtData.Value.Cmp(zero) == 0 | ||
| if isValueZero && arePropertiesEmpty(esdtData.Properties) { | ||
| return userAcnt.DataTrieTracker().SaveKeyValue(key, nil) |
There was a problem hiding this comment.
will this remove the key also? or the key remains but with null value?
There was a problem hiding this comment.
this removes the key.
| @@ -265,12 +265,26 @@ func checkFrozeAndPause( | |||
| return nil | |||
| } | |||
|
|
|||
| func arePropertiesEmpty(properties []byte) bool { | |||
| for _, property := range properties { | |||
There was a problem hiding this comment.
could use an early if len(properties) > 0 { return false }
There was a problem hiding this comment.
no. as if you do len(make([]byte, 10)) it returns 10
iulianpascalau
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete nil esdt data