ESDT system SC correct initialization at end-of-epoch #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurobert
reviewed
Apr 10, 2021
vm/systemSmartContracts/esdt.go
Outdated
| @@ -762,7 +769,8 @@ func (e *esdt) togglePause(args *vmcommon.ContractCallInput, builtInFunc string) | |||
| } | |||
|
|
|||
| func (e *esdt) configChange(args *vmcommon.ContractCallInput) vmcommon.ReturnCode { | |||
| if !bytes.Equal(args.CallerAddr, e.ownerAddress) { | |||
| icCorrectCaller := bytes.Equal(args.CallerAddr, e.ownerAddress) || bytes.Equal(args.CallerAddr, e.endOfEpochSCAddress) | |||
sasurobert
previously approved these changes
Apr 10, 2021
SebastianMarian
previously approved these changes
Apr 10, 2021
vm/errors.go
Outdated
| @@ -83,12 +83,12 @@ var ErrNilMessageSignVerifier = errors.New("nil message sign verifier") | |||
| // ErrNilStakingSmartContractAddress signals that staking smart contract address is nil | |||
| var ErrNilStakingSmartContractAddress = errors.New("nil staking smart contract address") | |||
|
|
|||
| // ErrNilEndOfEpochSmartContractAddress signals that the end of epoch smart contract address is nil | |||
| var ErrNilEndOfEpochSmartContractAddress = errors.New("nil end of epoch contract address") | |||
There was a problem hiding this comment.
nil end of epoch smart contract address
iulianpascalau
dismissed stale reviews from SebastianMarian and sasurobert
via
a7ab63f
SebastianMarian
approved these changes
Apr 10, 2021
sasurobert
approved these changes
Apr 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configChangewill work as expected.Testing scenario: launch a testnet, wait until ESDT feature becomes active (epoch 4) and try issue an ESDT with a base issuing value less than 5 eGLD. The transaction should fail. When trying to issue an ESDT with 5 eGLD, it should work. Use the
erd1fpkcgel4gcmh8zqqdt043yfcn5tyx8373kg6q2qmkxzu4dqamc0swts65caddress (pem file is located in elrond-go/cmd/node/testKeys/esdtWalletKey.pem) to send a transaction with the following parameters:Meaning: "change the ESDT configuration: set the owner to 486d8467f546377388006adf5891389d16431e3e8d91a0281bb185cab41dde1f which is erd1fpkcgel4gcmh8zqqdt043yfcn5tyx8373kg6q2qmkxzu4dqamc0swts65c, set the base issuing cost to 0.05 eGLD and set the minimum and maximum name lengths to 10 and 20 respectively"
The transaction should succeed.
Now, try issuing a new ESDT token with 0.05eGLD. The token should be issued (transaction succeeded).