Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

balanced destination shard as observer #2992

Merged
merged 3 commits into from
Apr 12, 2021

Conversation

bogdan-rosianu
Copy link
Contributor

@bogdan-rosianu bogdan-rosianu commented Apr 12, 2021

different destination shard as an observer when no shard is specified. same as #2960 but targeted to master branch

Testing procedure:

  • start an observer by using this branch
  • if the key is not in consensus and the node will start as observer, it should be routed to a "random" shard. The same key in multiple tries should be routed to the same shard.
  • try with multiple keys in order to see the shard balancing

@bogdan-rosianu bogdan-rosianu self-assigned this Apr 12, 2021
@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #2992 (77fc4f0) into master (3d326fa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 77fc4f0 differs from pull request most recent head 2a3cc95. Consider uploading reports for the commit 2a3cc95 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2992   +/-   ##
=======================================
  Coverage   75.02%   75.02%           
=======================================
  Files         620      620           
  Lines       59086    59094    +8     
=======================================
+ Hits        44329    44337    +8     
  Misses      10803    10803           
  Partials     3954     3954           
Impacted Files Coverage Δ
core/converters.go 86.90% <100.00%> (+1.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d326fa...2a3cc95. Read the comment docs.

@bogdan-rosianu bogdan-rosianu marked this pull request as ready for review April 12, 2021 08:44
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ssytem test passed

@iulianpascalau iulianpascalau merged commit d8f8836 into master Apr 12, 2021
@iulianpascalau iulianpascalau deleted the balanced-dest-sh-obserserver-master branch April 12, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants