Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nft transfer and execute from user to smart contract #2997

Merged
merged 2 commits into from
Apr 12, 2021

Conversation

sasurobert
Copy link
Contributor

fix nft transfer and execute from user to smart contract

@iulianpascalau iulianpascalau self-requested a review April 12, 2021 15:42
@@ -936,13 +935,17 @@ func (sc *scProcessor) treatExecutionAfterBuiltInFunc(
return true, userErrorVmOutput, newVMInput, sc.ProcessIfError(acntSnd, vmInput.CurrentTxHash, tx, err.Error(), []byte(""), snapshot, vmInput.GasLocked)
}

err = sc.checkUpgradePermission(acntDst, newVMInput)
newDestSC, err := sc.getAccountFromAddress(vmInput.RecipientAddr)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this backwards compatible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. it is. there is no execution after built in only after esdt is enabled.

@sasurobert sasurobert merged commit d238e97 into feat/eip-esdt-local-mint Apr 12, 2021
@sasurobert sasurobert deleted the fix-transfer-nft-to-sc branch April 12, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants