Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed integration tests #3003

Merged
merged 2 commits into from
Apr 14, 2021
Merged

Conversation

iulianpascalau
Copy link
Contributor

  • removed advertiser from processing integration tests
  • split vm/esdt in multiple packages

TODO: fix TestIssueESDT_FromSCWithNotEnoughGas test

- split vm/esdt in multiple packages
mihaib79
mihaib79 previously approved these changes Apr 13, 2021
@@ -150,6 +141,12 @@ func prepareNodes(
_ = nodes[i].Bootstrap()
}

for i := 0; i < len(nodes); i++ {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i < len(nodes) - 1 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks

func ConnectNodes(nodes []Connectable) {
encounteredErrors := make([]error, 0)

for i := 0; i < len(nodes); i++ {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i < len(nodes) - 1 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks

@LucianMincu LucianMincu merged commit 42fc831 into feat/eip-esdt-local-mint Apr 14, 2021
@LucianMincu LucianMincu deleted the fix-integration-tests branch April 14, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants