Fix transfer back asynccall #3015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3015 +/- ##
=======================================
Coverage 75.08% 75.08%
=======================================
Files 629 629
Lines 60808 60826 +18
=======================================
+ Hits 45658 45672 +14
- Misses 11035 11037 +2
- Partials 4115 4117 +2
Continue to review full report at Codecov.
|
iulianpascalau
requested changes
Apr 16, 2021
process/smartContract/process.go
Outdated
| @@ -1250,6 +1250,22 @@ func (sc *scProcessor) addBackTxValues( | |||
| scrIfError.Value = big.NewInt(0).Set(valueForSnd) | |||
| } | |||
|
|
|||
| if sc.flagSenderInOutTransfer.IsSet() && | |||
There was a problem hiding this comment.
should use a bool var here
ccorcoveanu
previously approved these changes
Apr 16, 2021
iulianpascalau
previously approved these changes
Apr 16, 2021
sasurobert
dismissed stale reviews from iulianpascalau and ccorcoveanu
via
6f91842
ccorcoveanu
previously approved these changes
Apr 16, 2021
ccorcoveanu
approved these changes
Apr 16, 2021
LucianMincu
approved these changes
Apr 16, 2021
iulianpascalau
approved these changes
Apr 16, 2021
bogdan-rosianu
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the value to the destination if async callback fails