Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit miniblocks to shardlimit #3016

Merged
merged 11 commits into from
Apr 16, 2021
Merged

Conversation

sasurobert
Copy link
Contributor

Limit miniblocks to shardlimit - no gasRefund on cross shard miniblock gas limit computation

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #3016 (8f4844a) into master (026576a) will not change coverage.
The diff coverage is 33.33%.

❗ Current head 8f4844a differs from pull request most recent head f74e523. Consider uploading reports for the commit f74e523 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3016   +/-   ##
=======================================
  Coverage   75.08%   75.08%           
=======================================
  Files         629      629           
  Lines       60826    60826           
=======================================
  Hits        45672    45672           
- Misses      11037    11038    +1     
+ Partials     4117     4116    -1     
Impacted Files Coverage Δ
process/block/preprocess/basePreProcess.go 72.13% <0.00%> (-0.55%) ⬇️
process/block/preprocess/transactions.go 52.54% <0.00%> (-0.15%) ⬇️
process/block/postprocess/basePostProcess.go 72.11% <100.00%> (ø)
process/block/baseProcess.go 68.87% <0.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 026576a...f74e523. Read the comment docs.

AdoAdoAdo
AdoAdoAdo previously approved these changes Apr 16, 2021
bogdan-rosianu and others added 5 commits April 16, 2021 13:42
@LucianMincu LucianMincu merged commit 2829c51 into master Apr 16, 2021
@LucianMincu LucianMincu deleted the limit-miniblocks-to-shardlimit branch April 16, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants