Fixed staking processors for the API routes #3024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miiu96
previously approved these changes
Apr 19, 2021
AdoAdoAdo
reviewed
Apr 19, 2021
| val := &api.DirectStakedValue{ | ||
| Address: dslp.publicKeyConverter.Encode(leafKey), | ||
| Staked: totalStakedCurrentAccount.String(), | ||
| Staked: staked.String(), |
There was a problem hiding this comment.
The separation into Staked and Total is misleading, as topup is also staked.
Can the field "staked" be renamed into base stake?
sasurobert
previously approved these changes
Apr 19, 2021
sasurobert
approved these changes
Apr 19, 2021
miiu96
approved these changes
Apr 19, 2021
Codecov Report
@@ Coverage Diff @@
## master #3024 +/- ##
=======================================
Coverage 75.08% 75.08%
=======================================
Files 629 629
Lines 60826 60831 +5
=======================================
+ Hits 45670 45675 +5
Misses 11039 11039
Partials 4117 4117
Continue to review full report at Codecov.
|
AdoAdoAdo
approved these changes
Apr 19, 2021
raduchis
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing scenario: do a top-up stake on an existing node. The routes:
/network/economicsshould return theerd_total_base_staked_valuevalue as a multiple of 2500 anderd_total_top_up_valuethe exact top-up-ed value. Next, the/network/direct-staked-infoshould return the correct value for that top-up-ed address (theBaseStakedshould be a 2500 multiple, theTopUpshould contain the top up value and theTotalshould be BaseStaked + TopUp)