Component for scheduled SCRs #3038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SebastianMarian
commented
Apr 23, 2021
•
SebastianMarian
commented
- Implemented functionality of saving/loading/setting/getting for scheduled scrs generated after execution of scheduled txs. These scrs should be included in the next block after the one in which the corresponding scheduled txs were included and afterwards were executed.
SebastianMarian
changed the title
SebastianMarian
changed the title
sasurobert
requested changes
Apr 28, 2021
AdoAdoAdo
reviewed
Apr 30, 2021
| ) | ||
|
|
||
| // ScheduledTxsExecutionStub - | ||
| type ScheduledTxsExecutionStub struct { |
There was a problem hiding this comment.
can we add instead one mock and/or one stub for the scheduledTxsExecution in testscommon ?
then we don't need to redefine in every package
| FeeHandler: &mock.FeeAccumulatorStub{}, | ||
| BlockSizeComputation: &mock.BlockSizeComputationStub{}, | ||
| BalanceComputation: &mock.BalanceComputationStub{}, | ||
| EconomicsFee: &mock.FeeHandlerStub{ |
There was a problem hiding this comment.
This is the way it is automatically formatted. I'm not sure if something is wrong with my settings or not...
AdoAdoAdo
previously approved these changes
May 6, 2021
sasurobert
previously approved these changes
May 6, 2021
process/sync/baseSync.go
Outdated
| @@ -695,6 +699,18 @@ func (boot *baseBootstrap) rollBack(revertUsingForkNonce bool) error { | |||
| ) | |||
| } | |||
|
|
|||
| mapScheduledSCRs, err := process.GetScheduledSCRsFromStorage(prevHeaderHash, boot.store, boot.marshalizer) | |||
| if err != nil { | |||
| log.Debug("get scheduled scrs from storage", | |||
There was a problem hiding this comment.
shouldn't be this critical ?
maybe make a new function for lines 702 - 713 as the base function is already too big
AdoAdoAdo
approved these changes
May 6, 2021
sasurobert
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.