Consensus scheduled block #3136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lock # Conflicts: # process/mock/headerHandlerStub.go # sharding/mock/headerHandlerStub.go
consensus/spos/scheduledProcessor.go
Outdated
| processingErrorString = "processing error" | ||
| inProgressString = "processing in progress" | ||
| processingOKString = "processing OK" | ||
| unexpectedString = "processing OK" |
There was a problem hiding this comment.
maybe change the string here?
iulianpascalau
previously approved these changes
Jun 1, 2021
sasurobert
reviewed
Jun 1, 2021
consensus/spos/bls/subroundBlock.go
Outdated
| @@ -160,8 +162,8 @@ func (sr *subroundBlock) createBlock(header data.HeaderHandler) (data.HeaderHand | |||
|
|
|||
| // sendBlockBodyAndHeader method sends the proposed block body and header in the subround Block | |||
| func (sr *subroundBlock) sendBlockBodyAndHeader( | |||
There was a problem hiding this comment.
if you changed the order. maybe rename the method name as well to sendHeaderAndBlockBody
There was a problem hiding this comment.
renamed, the parameter order was changed for consistency with the other methods.
…e consensus revert account state
| return sp == nil | ||
| } | ||
|
|
||
| func (sp *scheduledProcessorWrapper) emptyStopChannel() { |
There was a problem hiding this comment.
this resembles with the core.EmptyChannel function. could have used that by changing stopExecution to be a buffered chan of type bool.
iulianpascalau
approved these changes
Jun 3, 2021
sasurobert
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request starts the pipeline processing for the proposer and validators during consensus for the v2 blocks with scheduled miniblocks and validates the end result.
The proposer does not send the block final info if either there was an error with the block processing (coding errors - should be caught during testing phase if any) or timeout during execution - this is tricky and could happen in case of bad gas estimation, or starved processor.
As the consensus round is elastic, with early finalization in case all signatures are received ahead of time, the checking for the scheduled miniblocks execution result is delayed until either a final status is available or the scheduled mb execution has timedout.