cmd, epochStart, integrationTests: fix failed activation #3182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3182 +/- ##
=======================================
Coverage 75.37% 75.37%
=======================================
Files 630 630
Lines 61791 61796 +5
=======================================
+ Hits 46573 46578 +5
Misses 11064 11064
Partials 4154 4154
Continue to review full report at Codecov.
|
sasurobert
reviewed
Jun 17, 2021
epochStart/metachain/rewardsV2.go
Outdated
| @@ -56,19 +54,15 @@ func NewRewardsCreatorV2(args RewardsCreatorArgsV2) (*rewardsCreatorV2, error) { | |||
| if check.IfNil(args.EconomicsDataProvider) { | |||
| return nil, epochStart.ErrNilEconomicsDataProvider | |||
| } | |||
| if args.TopUpGradientPoint.Cmp(zero) < 0 { | |||
| if check.IfNil(args.RewardsHandler) { | |||
| return nil, epochStart.ErrInvalidRewardsTopUpGradientPoint | |||
sasurobert
reviewed
Jun 17, 2021
iulianpascalau
approved these changes
Jun 17, 2021
bogdan-rosianu
approved these changes
Jun 17, 2021
mihaieremia
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR activates the APR changes which failed to activate previously due to some duplicated code.
Duplicated code was removed and rewards computation uses the common handler which is aware of the changed parameters.