-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the node redundancy mechanism #3465
Conversation
|
||
nodeSkBytes, err := cryptoComponents.PrivateKey().ToByteArray() | ||
require.Nil(t, err) | ||
observerSkBytes, err := managedProcessComponents.NodeRedundancyHandler().ObserverPrivateKey().ToByteArray() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go lint
Codecov Report
@@ Coverage Diff @@
## master #3465 +/- ##
==========================================
- Coverage 73.85% 73.85% -0.01%
==========================================
Files 579 579
Lines 73400 73407 +7
==========================================
+ Hits 54209 54213 +4
- Misses 14824 14825 +1
- Partials 4367 4369 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing scenario:
RedundancyLevel
value to 1.broadcasting message heartbeat message
message. Should not use the public key from the provided file (should not broadcast A's public key), but a random BLS key (you can find this random key by grepping ongenerated BLS private key for redundancy handler
).broadcasting message heartbeat message
, should find A's public key for a couple of times.