Fix health record creation error #3470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeniaminDrasovean
approved these changes
Sep 27, 2021
Codecov Report
@@ Coverage Diff @@
## master #3470 +/- ##
==========================================
- Coverage 73.85% 73.84% -0.01%
==========================================
Files 579 579
Lines 73415 73420 +5
==========================================
Hits 54217 54217
- Misses 14829 14834 +5
Partials 4369 4369
Continue to review full report at Codecov.
|
andreibancioiu
approved these changes
Sep 27, 2021
|
|
||
| func (nr *nodeRunner) doProfileOnShuffleOut() { | ||
| debugConfig := nr.configs.GeneralConfig.Debug.ShuffleOut | ||
| shouldDoProfile := debugConfig.DoProfileOnShuffleOut && nr.configs.FlagsConfig.UseHealthService |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing scenario: start a regular internal testnet using the
masterbranch and without the-use-health-serviceon the node start line. After upgrade & some shuffle out processes, when grepping the logs forERRORyou will find some lines likeopen /home/xxx/elrond-nodes/node-0/health-records/mem__softrestart__xxx__xxx_MB.pprof: no such file or directory(this is just to prove the
masterbranch has the wrong code)Repeat these steps with this branch. Should no longer find
ERRORmessages. Then reactivate the-use-health-serviceflag and give it a proper #all-in scenario.