Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve tx cost computation #3472

Merged
merged 3 commits into from
Sep 28, 2021
Merged

improve tx cost computation #3472

merged 3 commits into from
Sep 28, 2021

Conversation

bogdan-rosianu
Copy link
Contributor

small improvement for the situation when the transaction to be estimated is a simple move balance

@bogdan-rosianu bogdan-rosianu added the type:feature New feature or request label Sep 28, 2021
@bogdan-rosianu bogdan-rosianu self-assigned this Sep 28, 2021
@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #3472 (83e74d3) into master (54b931d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3472   +/-   ##
=======================================
  Coverage   73.83%   73.84%           
=======================================
  Files         579      579           
  Lines       73420    73427    +7     
=======================================
+ Hits        54212    54219    +7     
- Misses      14837    14838    +1     
+ Partials     4371     4370    -1     
Impacted Files Coverage Δ
process/transaction/transactionCostEstimator.go 74.01% <100.00%> (-2.66%) ⬇️
p2p/libp2p/netMessenger.go 75.00% <0.00%> (+0.41%) ⬆️
storage/txcache/txListBySenderMap.go 100.00% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54b931d...83e74d3. Read the comment docs.

Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.
New error will be solved when development will go intro master.
image

@LucianMincu LucianMincu merged commit 6922167 into master Sep 28, 2021
@LucianMincu LucianMincu deleted the tx-cost-improvements branch September 28, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants