-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed connect to seeders print + main print #3473
Conversation
93e98a1
Codecov Report
@@ Coverage Diff @@
## master #3473 +/- ##
==========================================
- Coverage 73.85% 73.85% -0.01%
==========================================
Files 579 579
Lines 73407 73415 +8
==========================================
+ Hits 54215 54217 +2
- Misses 14824 14829 +5
- Partials 4368 4369 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System test passed.
Testing scenario:
master
branch and run it in a new folder without the config folders. The node will close itself without printing any messages. Repeat the step from this branch: should see a log print error message.2.a. run node (with configs) from
master
branch (no seeder, nothing else and log level-log-level *:DEBUG
). You should see the log debug printerror connecting to seeder
(this is correct).2.b. Now, change in the p2p.toml file, place these seeders:
you can still see the log print as debug stating
error connecting to seeder
and mentioning something about an unwanted peer.2.c. re-run the same scenario with the same steps (run the node with
-log-level *:DEBUG,p2p:TRACE
) and for scenario 2a. you will see the print as log debug. For repeating 2b., you will see a TRACE message statingtryConnectToSeeder: unwanted peer
and no log debugerror connecting to seeder
.