registerVM-gasSchedule-notifier #3491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianMarian
previously approved these changes
Oct 4, 2021
iulianpascalau
previously approved these changes
Oct 4, 2021
Codecov Report
@@ Coverage Diff @@
## development #3491 +/- ##
===============================================
- Coverage 73.86% 73.85% -0.01%
===============================================
Files 581 581
Lines 73843 73847 +4
===============================================
- Hits 54543 54541 -2
- Misses 14927 14930 +3
- Partials 4373 4376 +3
Continue to review full report at Codecov.
|
sasurobert
dismissed stale reviews from iulianpascalau and SebastianMarian
via
0c86eb4
SebastianMarian
previously approved these changes
Oct 4, 2021
iulianpascalau
previously approved these changes
Oct 4, 2021
| @@ -131,7 +131,9 @@ func (g *gasScheduleNotifier) EpochConfirmed(epoch uint32, _ uint64) { | |||
|
|
|||
| g.lastGasSchedule = newGasSchedule | |||
| for _, handler := range g.handlers { | |||
| handler.GasScheduleChange(g.lastGasSchedule) | |||
| if !check.IfNil(handler) { | |||
There was a problem hiding this comment.
this is a safe check but a nil handler could never be added in the handlers as the RegisterNotifyHandler function has already a nil check for each handler it adds
sasurobert
dismissed stale reviews from iulianpascalau and SebastianMarian
via
7cfffce
SebastianMarian
approved these changes
Oct 5, 2021
AdoAdoAdo
approved these changes
Oct 5, 2021
iulianpascalau
approved these changes
Oct 5, 2021
|
Initial system tests passed. |
LucianMincu
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register VM to gasschedule notifier