Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logs issue esdt #3492

Merged
merged 6 commits into from
Oct 7, 2021
Merged

logs issue esdt #3492

merged 6 commits into from
Oct 7, 2021

Conversation

miiu96
Copy link
Contributor

@miiu96 miiu96 commented Oct 4, 2021

  • Added logs and events for issue operations. When a new ESDT token will be issued a log will be generated.

Log entry will contain:

  • Topics[0] - token identifier
  • Topics[1] - token name
  • Topics[2] - ticker name
  • Topics[3] - token type

@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #3492 (e09840f) into development (84eb5d1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #3492   +/-   ##
============================================
  Coverage        73.85%   73.85%           
============================================
  Files              581      581           
  Lines            73869    73894   +25     
============================================
+ Hits             54555    54578   +23     
- Misses           14940    14941    +1     
- Partials          4374     4375    +1     
Impacted Files Coverage Δ
vm/systemSmartContracts/esdt.go 81.98% <100.00%> (+0.37%) ⬆️
process/block/baseProcess.go 68.69% <0.00%> (-0.26%) ⬇️
p2p/libp2p/netMessenger.go 75.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c4ee9a...e09840f. Read the comment docs.

Address: args.CallerAddr,
Topics: [][]byte{tokenIdentifier, args.Arguments[0], args.Arguments[1], []byte(core.SemiFungibleESDT)},
}
e.eei.AddLogEntry(logEntry)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have to do the same for MetaESDT as well. And for change into metaESDT as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.
Flags are ok.
image

@miiu96 miiu96 merged commit 8bb134b into development Oct 7, 2021
@miiu96 miiu96 deleted the logs-issue-esdt branch October 7, 2021 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants