Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arwen 1.4.17 #3495

Merged
merged 7 commits into from
Oct 8, 2021
Merged

Arwen 1.4.17 #3495

merged 7 commits into from
Oct 8, 2021

Conversation

sasurobert
Copy link
Contributor

new arwen which returns only changed storage data

@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #3495 (b573b38) into development (6e71b8e) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3495      +/-   ##
===============================================
- Coverage        73.85%   73.85%   -0.01%     
===============================================
  Files              581      581              
  Lines            73907    73907              
===============================================
- Hits             54585    54583       -2     
- Misses           14944    14945       +1     
- Partials          4378     4379       +1     
Impacted Files Coverage Δ
p2p/libp2p/netMessenger.go 74.72% <0.00%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c715ba1...b573b38. Read the comment docs.

SebastianMarian
SebastianMarian previously approved these changes Oct 7, 2021
@@ -167,6 +167,7 @@
BigIntGetSignedArgument = 100
BigIntGetCallValue = 100
BigIntGetExternalBalance = 500
CopyPerByteForTooBig = 1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename this, something doesn't sounds too well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not have a better idea. This is exactly what is does.it is a protection

gabi-vuls
gabi-vuls previously approved these changes Oct 8, 2021
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.
Problems were analyzed and they are safe.
image

Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System tests passed.

@LucianMincu LucianMincu merged commit 8d93b2b into development Oct 8, 2021
@LucianMincu LucianMincu deleted the arwen-1.4.17 branch October 8, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants