Added metric for max gas per transaction #3496
Conversation
node/nodeRunner.go
Outdated
| @@ -556,7 +557,7 @@ func (nr *nodeRunner) createMetrics( | |||
| metrics.SaveStringMetric(managedCoreComponents.StatusHandler(), common.MetricRewardsTopUpGradientPoint, managedCoreComponents.EconomicsData().RewardsTopUpGradientPoint().String()) | |||
| metrics.SaveStringMetric(managedCoreComponents.StatusHandler(), common.MetricTopUpFactor, fmt.Sprintf("%g", managedCoreComponents.EconomicsData().RewardsTopUpFactor())) | |||
| metrics.SaveStringMetric(managedCoreComponents.StatusHandler(), common.MetricGasPriceModifier, fmt.Sprintf("%g", managedCoreComponents.EconomicsData().GasPriceModifier())) | |||
|
|
|||
| metrics.SaveUint64Metric(managedCoreComponents.StatusHandler(), common.MetricMaxGasPerTransaction, managedCoreComponents.EconomicsData().MaxGasLimitPerMiniBlock(selfShardID)) | |||
There was a problem hiding this comment.
maybe use managedCoreComponents.EconomicsData().MaxGasLimitPerMiniBlockForSafeCrossShard()
There was a problem hiding this comment.
good catch. done
process/economics/economicsData.go
Outdated
| @@ -708,6 +708,8 @@ func (ed *economicsData) setGasLimitConfig(currentEpoch uint32) { | |||
| "maxGasLimitPerMetaMiniBlock", ed.maxGasLimitPerMetaMiniBlock, | |||
| "minGasLimit", ed.minGasLimit, | |||
| ) | |||
|
|
|||
| ed.statusHandler.SetUInt64Value(common.MetricMaxGasPerTransaction, ed.maxGasLimitPerMiniBlock) | |||
There was a problem hiding this comment.
MaxGasLimitPerMiniBlockForSafeCrossShard?
There was a problem hiding this comment.
I cannot use that function because it has mutex protection and I already am inside a function with mutex protection (until defer). However, I've set the metric value the minimum between shard miniblock limit and meta miniblock limit (just as in that function)
| @@ -171,6 +171,7 @@ func (sm *statusMetrics) ConfigMetrics() map[string]interface{} { | |||
| configMetrics[common.MetricRewardsTopUpGradientPoint] = sm.loadStringMetric(common.MetricRewardsTopUpGradientPoint) | |||
| configMetrics[common.MetricGasPerDataByte] = sm.loadUint64Metric(common.MetricGasPerDataByte) | |||
| configMetrics[common.MetricChainId] = sm.loadStringMetric(common.MetricChainId) | |||
| configMetrics[common.MetricMaxGasPerTransaction] = sm.loadUint64Metric(common.MetricMaxGasPerTransaction) | |||
There was a problem hiding this comment.
add this new metric also in the test file
…nto added-max-tx-gas-limit-metric
Codecov Report
@@ Coverage Diff @@
## development #3496 +/- ##
===============================================
- Coverage 73.87% 73.87% -0.01%
===============================================
Files 582 582
Lines 74441 74444 +3
===============================================
+ Hits 54996 54998 +2
- Misses 15044 15045 +1
Partials 4401 4401
Continue to review full report at Codecov.
|
added
erd_max_gas_per_transactionmetric that will also be returned in the/network/configendpoint